Open
Conversation
Owner
|
You removed the debug log in the PR. It is a solution for your use case, but it is not general. I used temporary log files in past versions (see f1a2a9d ), I make the logging optional, so you can turn it off. |
ponty
pushed a commit
that referenced
this pull request
Feb 19, 2024
ponty
pushed a commit
that referenced
this pull request
Feb 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #92
The problem causing the issue above is that
Xvfbstarted to be a lot more chatty. Using it withchromeit keeps outputing the following on each connection:So there is a lot of data going through stderr if we make a lot of connection to the display. And currently the library assigns stdout and stderr to a subprocess
PIPEbut doesn't read from it until it stops it. Hence all this data is buffered and when the buffer is full it hangs the execution of the whole program.I am not sure if what I propose is the best solution but it seems that the
PIPEs aren't actually used, only to debug log everything at the end. Another solution could be to (optionally?) redirect stdout/stderr to a log file if we want to keep the debug data. Would be neat if we could redirect to a logger directly but unfortunately I don't think it is really possible in python.